Closed dcheremnov closed 2 years ago
@pmstss please don't close this one, it will be updated step by step
Change const name or switch to var in the second example
It doesn't make any sense, it is totally different code examples referees to different contexts.
Add required cluster property to example
This particular example shows the ability to use particular settings. I don't see any reason to specify all required params which just complicates understanding. BTW we can just use a comment (// ...
) to show there might be other params here.
Missing the IssueDetected definition or link to the Core example
The example is intended to show bind
usage, everything else is out of scope
BTW we can just use a comment (// ...) to show there might be other params here.
Looks like a solution.
Scan package:
[x] Fix the bar variable in the example. Query param accepts
string | string[]
only. https://github.com/NeuraLegion/sec-tester-js/blob/c73c789ee359766dab980161fe51104f27973616/packages/scan/README.md?plain=1#L132-L137[x] According to the documentation, I expect that timeout was set in seconds. While it is in minutes. https://github.com/NeuraLegion/sec-tester-js/blob/c73c789ee359766dab980161fe51104f27973616/packages/scan/README.md?plain=1#L62
[x] Formdata doesn't have set() method anymore (?).
Repeater:
Core:
// ...
) to show there might be other params here https://github.com/NeuraLegion/sec-tester-js/blob/0e8cc4ef8605001293d868bdfc2046d77b556fb8/packages/core/README.md?plain=1#L96-L104 https://github.com/NeuraLegion/sec-tester-js/blob/0e8cc4ef8605001293d868bdfc2046d77b556fb8/packages/core/README.md?plain=1#L120-L127Generic type 'Command<T, R>' requires 2 type argument(s).ts(2314)
Bus: