search

NeuraLegion / shainet

SHAInet - a pure Crystal machine learning library
MIT License
183 stars 19 forks source link

logo add #89

Closed psikoz closed 6 years ago

bararchy commented 6 years ago

@psikoz Can we omit the PDF file? (shainet.ai)

psikoz commented 6 years ago

yes, i added the shainet.pdf

bararchy commented 6 years ago

@psikoz Sorry, I mean let's remove the .ai (and now also remove the .pdf file).

Those files are binary blobs which are bad Git context wise, it's also not needed as we have the .png file which are good enough. I guess you wanted to give us ability to further edit and approach the source of the logo files but it adds clutter to the lib, it also means that anyone cloning or using the lib as a Crystal shard will need to download those files.

I feel that giving around closed binary files is a security risk and just unneeded space. Let's keep only the .png files.

Thanks :)

psikoz commented 6 years ago

yeah, sensible! I removed the pdf and ai files.

sancarn commented 6 years ago

@psikoz I assume you included the pdf for scalability. Could alternatively include an SVG instead