search

NeuraLegion / shainet

SHAInet - a pure Crystal machine learning library
MIT License
181 stars 19 forks source link

Crystal 0.35.1 updates #96

Closed rmarronnier closed 4 years ago

rmarronnier commented 4 years ago

This PR takes care of deprecated JSON.Mapping, Time.new, and Logger

Note : Logs are not displayed when running crystal specs with the new Crystal::Log (but logs are displayed when using Shainet normally)

rmarronnier commented 4 years ago

Thanks for the review !

Ameba is not happy with the Log constant naming though : [Style/ConstantNames] Constant name should be screaming-cased: LOG, not Log

That's why I went against the specific Log naming convention initially but I'll change it.

I'll file an Ameba issue because other projects will face the same problem. Edit : Wrote too fast (https://github.com/crystal-ameba/ameba/issues/148)

Also, I'm curious : Is shainet used in production ? Do you (NeuraLegion) envision to make it grow ? Is it only maintained for educational purposes ?

ArtLinkov commented 4 years ago

@rmarronnier thanks for the PR, it is greatly appreciated :slightly_smiling_face:

Also, I'm curious : Is shainet used in production ? Do you (NeuraLegion) envision to make it grow ? Is it only maintained for educational purposes ?

Originally SHAInet was developed as a research and educational project, and for now we don't have any immediate plans to add additional production optimizations (like MT support, etc.). However, I do have some idea's in the back of my mind to add some cool features eventually, just waiting for some free time on my hands.

In regards to the growth of the project, absolutely! Right now it's mostly a community effort, we embrace all contributions :slightly_smiling_face:, but we do plan to allocate resources back to this project in the future

rmarronnier commented 4 years ago

@ArtLinkov Thanks for the comprehensive answer :-)

I'm not sure I can contribute much to Shainet (low level ML is out of my league). I might try though ;-)

However, I keep a tab on it hoping I can use it one day to implement some state of the art NLP processes for Cadmium.

ArtLinkov commented 4 years ago

Looks good, merging. @Sija thanks for the review :slightly_smiling_face: