search

Neural-Systems-at-UIO / WebAlign

https://webalign.readthedocs.io
MIT License
5 stars 3 forks source link

WebAlign removes nonlinear markers on save #31

Closed PolarBean closed 10 months ago

PolarBean commented 11 months ago

I like to go back and forth between webalign and webwarp in the workbench. but it appears that when i do it deletes my nonlinear markers. Would it be possible for it to only update the ouv and not the markers?

thank you in advance

Tevemadar commented 11 months ago

This is intentional, markers lose their meaning when base alignment changes. However deletion of markers is restricted, it happens to the section itself and the surrounding propagation block (so in both directions up to the next section which has its own alignement). There's a known issue though: "undo" doesn't restore deleted markers.

PolarBean commented 11 months ago

I understand that perspective, at the same time when I have spent 10 minutes creating the perfect deformation, and then decide to adjust the angle by 1 degree, I don't want to lose my markers.

You could have a popup when the users comes back to say "this files alignments have changed since you last set the markers, should we clear the markers of the adjusted sections?"

Tevemadar commented 10 months ago

Feature disabled in https://github.com/Neural-Systems-at-UIO/WebAlign/commit/4ed0bf81d13291b37de8db83410710c9068dc016