NeuralAnalysis / TrialData

Code base for the Matlab TrialData analysis library.
3 stars 4 forks source link

dupeAndShift interacts weirdly with re-binning #2

Closed mattperich closed 6 years ago

mattperich commented 7 years ago

Basically, if you re-bin with truncateAndBin AFTER dupeAndShift, everything is screwed up. Will need to add a section to truncateAndBin that looks for _shift fields and rebins them accordingly (if that makes sense... otherwise, just automatically deletes the field and calls dupeAndShift again with the rebinned data).

raeedcho commented 6 years ago

This is super old, but is this just a problem with truncateAndBin, or does it also affect trimTD and binTD?

If this isn't an issue anymore, let's close it.

mattperich commented 6 years ago

As far as I've seen, binTD/trimTD and dupeAndShift work well together in any order. However, just to note, remember that you lose bins of time when you dupeAndShift due to the non-overlapping segments so it's often best to dupeAndShift before the final trimTD call.

I am closing this issue now.