search

NeuralEnsemble / PyNN

A Python package for simulator-independent specification of neuronal network models.
Other
276 stars 126 forks source link

Add support for irregular sampling intervals when recording #754

Closed apdavison closed 2 years ago

apdavison commented 2 years ago

for NEURON with cvode or for BrainScaleS-2

coveralls commented 2 years ago

Coverage Status

Coverage decreased (-0.02%) to 69.847% when pulling b34e53a703f67db29af7a9913c7ff282f7bcc68f on apdavison:irregular-sampling into 5bf3823cee5e04fa0ad40b36c3f4e71aad6d1630 on NeuralEnsemble:master.

AvidusMauch commented 2 years ago

saving IrregularlySampledSignal types in segment.analogsignals seams to break write/read_block of NeoMatlabIO probably because it only expects AnalogSingal in that array. IrregularlySampledSignals are meant to be stored in segment.irregularlysampledsignals probably? Or do IrregularlySampledSignals just need to be supported in general by NeoMatlabIO?

apdavison commented 2 years ago

@AvidusMauch thanks for spotting that. Indeed, IrregularlySampledSignals are meant to be stored in segment.irregularlysampledsignals.

(this is likely to change before we release Neo 1.0, but for now it is the case)

apdavison commented 2 years ago

also, NeoMatlabIO doesn't support IrregularlySampledSignal - I've opened a ticket for this: https://github.com/NeuralEnsemble/python-neo/issues/1126