Change of default behavior for MAXIMA_THRESHOLD_WINDOW

NeuralEnsemble / cobrawap

Collaborative Brain Wave Analysis Pipeline (Cobrawap)

https://cobrawap.readthedocs.io/

GNU General Public License v3.0

17 stars 16 forks source link

Change of default behavior for MAXIMA_THRESHOLD_WINDOW #49

Closed cosimolupo closed 3 months ago

cosimolupo commented 2 years ago

MAXIMA_THRESHOLD_WINDOW has now a default value equal to 'None', corresponding to set it equal to the entire signal duration. Also accepts float values.
Little fix involving plot_minima function in minima.py script, now plotting the interpolated position of minima when required.

mdenker commented 8 months ago

@cosimolupo Please look through again and update.

cosimolupo commented 8 months ago

@mdenker, I re-aligned this branch to the current HEAD of NeuralEnsemble/cobrawap, and then added back all the changes, updating them according to our recent discussions and to @rgutzen's comments above.

gulpgiulia commented 8 months ago

I went through the proposed changes and checked for consistency and coherence; done from my side

mdenker commented 5 months ago

After final look and review, merge together with version number increase #62 and #63

mdenker commented 4 months ago

@rgutzen Please recheck the latest changes.