specify upper bound for snakemake version for support of subworkflows

NeuralEnsemble / cobrawap

Collaborative Brain Wave Analysis Pipeline (Cobrawap)

https://cobrawap.readthedocs.io/

GNU General Public License v3.0

17 stars 16 forks source link

specify upper bound for snakemake version for support of subworkflows #58

Closed rgutzen closed 8 months ago

rgutzen commented 9 months ago

snakemake >= 8.0.0 introduces breaking changes, including dropping support for the deprecated 'subworkflow' feature which is used in cobrawap. Ultimately, we must adopt the suggested alternative "module" feature to realize the same functionality. See issue #57. For now, this PR limits the snakemake version to < 8.0.0, so that it still works with the corresponding dependencies when installed via pip.

mdenker commented 9 months ago

Thanks @rgutzen for taking care of this! Dear @cosimolupo and @gulpgiulia : I added us three as reviewers to this PR, let's use it to practice :-)