Closed Moritz-Alexander-Kern closed 8 months ago
Hello @Moritz-Alexander-Kern! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
elephant/current_source_density.py
:Line 284:9: E741 ambiguous variable name 'I' Line 296:9: E741 ambiguous variable name 'I'
This pull request (PR) replaces the usage of the
sp.sqrt
function withnp.sqrt
.The deprecation of sp.sqrt expired earlier than expected. Originally, it was planned to be removed with the release of scipy 2.0.0, but with scipy version greater than 1.10.1, unit tests are failing.
Deprecation was introduced in scipy 1.4.0:
https://docs.scipy.org/doc/scipy/release/1.4.0-notes.html#scipy-deprecations
Quote from the scipy release notes:
Support for NumPy functions exposed via the root SciPy namespace is deprecated and will be removed in 2.0.0. For example, if you use scipy.rand or scipy.diag, you should change your code to directly use numpy.random.default_rng or numpy.diag, respectively. They remain available in the currently continuing Scipy 1.x release series.
Further deprecations fixed: