NeuralEnsemble / python-neo

Neo is a package for representing electrophysiology data in Python, together with support for reading a wide range of neurophysiology file formats
http://neo.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
307 stars 240 forks source link

SpikeGLX: add Ultra and NP-Opto types #1459

Closed alejoe91 closed 1 month ago

alejoe91 commented 1 month ago

Fixes #1451

also adding Ultra-beta variant (1121) ant NP-Opto (1300). All these models are based on NP1.0 technology

@CodyCBakerPhD

zm711 commented 1 month ago

This looks fine to me. Are there any test files that could help us double check that adding just there works (other than seeing that it seemed to work in the issue)?

alejoe91 commented 1 month ago

I don't have any, but it should be fine :)

alejoe91 commented 1 month ago

Test data uploaded here: https://gin.g-node.org/NeuralEnsemble/ephy_testing_data/pulls/129

@zm711 could you check (and merge) the GIN PR?

zm711 commented 1 month ago

Merged :) and just reran tests.