search

NeuralEnsemble / python-neo

Neo is a package for representing electrophysiology data in Python, together with support for reading a wide range of neurophysiology file formats
http://neo.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
325 stars 248 forks source link

[NeuralynxRawIO] Clean time parsing #1568

Open PeterNSteinmetz opened 2 months ago

PeterNSteinmetz commented 2 months ago

At long last, replaced the complicated header dictionaries with more general patterns and checks. There are a few more tweaks on this that will be nice but this is a good chunk. As before, depends on the prior chain with NeuraviewTestAndRefactor.

PeterNSteinmetz commented 1 month ago

Sadly the delay in review has now caused there to be conflicts between my others use of the latest master python-neo and these changes. I guess no conflicts with python-neo per se yet.

I think this is the sort of thing that causes a lot of potential contributors to give up.

PeterNSteinmetz commented 1 month ago

I should also mention that the change to the BaseRawIO._signal_channel_dtype broke a lot of derived classes that I have. I know that is not part of the public interface but thought I should mention it.

zm711 commented 3 weeks ago

Hey Peter yeah, sorry the buffer io was something we had planned for quite a spell and needed to get done. Sam was putting all of his effort into that lately. We have one last big buffer based set of changes, but reviewing these PRs is on Sam's todo list. (I remind him to do it :) )

PeterNSteinmetz commented 3 weeks ago

I guess I don't understand the need for buffer_id, even having read the enhancement proposal, but I assume it is important at some level.

I ended up merging the changes in this PR into my master branch forked from the main master. There weren't many conflicts so hopefully that should not be a problem in the future when these changes here are merged into the main master.