Neuraxio / Neuraxle

The world's cleanest AutoML library ✨ - Do hyperparameter tuning with the right pipeline abstractions to write clean deep learning production pipelines. Let your pipeline steps have hyperparameter spaces. Design steps in your pipeline like components. Compatible with Scikit-Learn, TensorFlow, and most other libraries, frameworks and MLOps environments.
https://www.neuraxle.org/
Apache License 2.0
608 stars 62 forks source link

ValidationSplitWrapper should use the same code as ValidationSplitter. #477

Closed vincent-antaki closed 2 years ago

vincent-antaki commented 3 years ago

While both of these have the same behaviour in term of splitting, they both contains the same or very similar code in their split_data_container and split functions.

I suggest we change the former to use the code of the latter. That being said I'm not totally sure in what context is the former used; it seems to have something to do with AutoMLSequentialWrapper which I am not familiar with. Furthermore, creation of a validation.py file might be necessary as to avoid import loop when doing the suggested change.