add support for L-BFGS - Githubissues

NeuroDiffGym / neurodiffeq

A library for solving differential equations using neural networks based on PyTorch, used by multiple research groups around the world, including at Harvard IACS.

http://pypi.org/project/neurodiffeq/

MIT License

699 stars 89 forks source link

add support for L-BFGS #91

Closed matinmoezzi closed 3 years ago

matinmoezzi commented 3 years ago

Add support for optimizers that need the closure function, such as L-BFGS and Conjugate Gradient optimizers.

shuheng-liu commented 3 years ago

Hi Matin, this is a great feature. However, there is a test case that didn't pass. Can you open another PR and merge it to the optim-closure (not optimizer-closure) branch so that I can investigate it further before we merge into master? Thanks a lot!

matinmoezzi commented 3 years ago

Hi Shuheng, all test cases passed in my local machine. The failure is that the directory is not empty. I faced this error in my local machine, but it was fixed after I deleted the 'runs' directory.