search

NeuroGrid / folk-on-the-hill

For the Harrow Folk Festival
MIT License
0 stars 2 forks source link

IE11 (Windows & problems) #18

Open tansaku opened 5 years ago

tansaku commented 5 years ago

the client says:

The website doesn't 'fit' my browser and I have to keep changing it to zoom out so it fits, this then means I have to zoom in on my other windows. We need to have it sized automatically so as to fit different people's settings/hardware.

tansaku commented 5 years ago

biographies-on-client-computer venues-on-client-computer

tansaku commented 5 years ago

client is experiencing the above on Windows 7 Home Premium running IE V11

tansaku commented 5 years ago

I can confirm that I have similar issues on that platform, the problems include:

  1. tickets section is not centered
  2. biographies section is blank
  3. map section is not centered
  4. venue section is stretched out
javpet commented 5 years ago

Hmm, it might be that some Flexbox features are not working properly in IE 11: https://caniuse.com/#search=flexbox

I know the client's browser is the ultimate browser where the site has to work. Checking the global usage of IE 11 is 2.37%. We might need to add "webkit-" or by feature queries: https://hacks.mozilla.org/2016/08/using-feature-queries-in-css/

This is a helpful site with all the known issues for IE10 / 11 https://github.com/philipwalton/flexbugs

javpet commented 5 years ago

Alternatively this prefixing can be tried too: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Flexible_Box_Layout/Mixins

javpet commented 5 years ago

Added some fixes: https://github.com/NeuroGrid/folk-on-the-hill/pull/new/18/2_fixing_IE_issues

tansaku commented 5 years ago

@javpet I think the link you posted above it not quite what you wanted - I edited the PR to say fixes #18 - to link issues and PRs the trick is to put the fixes #issue_number in the PR description to take full advantage of githubs automation :-)

tansaku commented 5 years ago

I was just looking at the changes on my IE and it's an improvement, but the images are all showing up at the wrong resolution ... I'll see if I can't get browserstack set up at some point ...