search

NeuroJSON / easyh5

EasyH5 Toolbox - An easy-to-use HDF5 data interface (loadh5 and saveh5) for MATLAB
BSD 3-Clause "New" or "Revised" License
13 stars 10 forks source link

Test easyh5 on older releases of MATLAB and improve for compatibility #8

Closed fangq closed 4 years ago

fangq commented 4 years ago

@ftadel reported various errors and warnings when running easyh5 on older versions of MATLAB (older than R2016 on which it was developed).

https://github.com/brainstorm-tools/brainstorm3/pull/283#issuecomment-623604198

fangq commented 4 years ago

more compatibility focused fixes to run easyh5 on matlab 2014 or earlier

https://github.com/fangq/easyh5/commit/ef1ccdcc69a3982bfe2cc4de60ab9a0efe0d8b4e

basically, matlab 2014b and earlier uses hdf5 1.8.6 (H5.get_libversion()), and this version of hdf5 can not save empty datasets, according to

https://github.com/h5py/h5py/issues/559 https://github.com/keras-team/keras/issues/3208

ftadel commented 4 years ago

Thanks. Reported here: https://github.com/brainstorm-tools/brainstorm3/commit/9a9da7ace2da0187ff0ac825c0d17df9b3d4366e