NeuroML / Documentation

Source repository for NeuroML documentation.
https://docs.neuroml.org
11 stars 9 forks source link

Binder not using latest main for notebooks (neither is Colab) #187

Closed pgleeson closed 10 months ago

pgleeson commented 10 months ago

Neither of these platfiorms seem to be using the latest version from main of the simple Izh example: https://docs.neuroml.org/Userdocs/NML2_examples/SingleNeuron.html. Binder doesn't recompile the docker image following a commit to main as it should, and Colab just goes straight to an older version of the notebook.

sanjayankur31 commented 10 months ago

Maybe theyre running off master instead of main? Not sure if this is configurable somewhere.

-- Thanks,

Ankur

(Sent from mobile device)

On Mon, 18 Dec 2023, 11:17 Padraig Gleeson, @.***> wrote:

Neither of these platfiorms seem to be using the latest version from main of the simple Izh example: https://docs.neuroml.org/Userdocs/NML2_examples/SingleNeuron.html. Binder doesn't recompile the docker image following a commit to main as it should, and Colab just goes straight to an older version of the notebook.

— Reply to this email directly, view it on GitHub https://github.com/NeuroML/Documentation/issues/187, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZBL2YX3GVMQ26WHUIOODYKAQ2XAVCNFSM6AAAAABAZLHOFGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2DMNBTGI2TQNA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

pgleeson commented 10 months ago

Yep, that seems to be the issue. From a quick search it's a known issue. Doesn't help that our repo was originally master then we moved to main... Simplest for now is to keep master up to date with main...

sanjayankur31 commented 10 months ago

The automatically generated link for the binder icon specifies master:

https://mybinder.org/v2/gh/NeuroML/Documentation/master?urlpath=tree/source/Userdocs/NML2_examples/SingleNeuron.ipynb

Not sure if that's hard coded in the theme or if there's a configuration somewhere. Will look.

pgleeson commented 10 months ago

Great, thanks for finding the fix!