search

NeuroML / NeuroML2

This repository hosts the NeuroML 2 Schema, the ComponentType definitions in LEMS and the core documentation of NeuroML2.
https://docs.neuroml.org
GNU Lesser General Public License v3.0
50 stars 24 forks source link

Update schema to correctly make components extend some base class #189

Closed sanjayankur31 closed 2 years ago

pgleeson commented 2 years ago

Looks good!

pgleeson commented 2 years ago

@sanjayankur31 Your tests on the pr passed, but now there is an issue:

---  Validating: /home/runner/work/NeuroML2/NeuroML2/org.neuroml.model/target/maven-shared-archive-resources/examples/NML2_SegmentConnections.nml
       File: /home/runner/work/NeuroML2/NeuroML2/org.neuroml.model/target/maven-shared-archive-resources/examples/NML2_SegmentConnections.nml is not valid against the schema: /Schemas/NeuroML2/NeuroML_v2.3.xsd!!
src-resolve: Cannot resolve the name 'BaseWithoutID' to a(n) 'type definition' component.
sanjayankur31 commented 2 years ago

Uh, I'll file a new issue for this and dig in to see what's up. What does the error mean, would you know?