search

NeuroML / pyNeuroML

A single package in Python unifying scripts and modules for reading, writing, simulating and analysing NeuroML2/LEMS models.
https://docs.neuroml.org/Userdocs/Software/pyNeuroML.html
GNU Lesser General Public License v3.0
36 stars 30 forks source link

Feat/issue 126: allow programmatic access to output of jnml from validation #127

Closed sanjayankur31 closed 3 years ago

jonrkarr commented 3 years ago

An option to get an error message as a string is great. The new output string is much more readable.

I tried the method, and the first Boolean output is true even for invalid models (where validation concludes with the message Validated 1 files: 0 passed, 1 failed).

Also, could you make the same change to validate_neuroml1?

sanjayankur31 commented 3 years ago

I tried the method, and the first Boolean output is true even for invalid models (where validation concludes with the message Validated 1 files: 0 passed, 1 failed).

Ah, that's odd. I'll look into that.

Also, could you make the same change to validate_neuroml1?

I'll do that, sure.

Please note: NeuroML v1 is deprecated and should not be used, and we intend to start dropping all of these functions soon (they only exist because we have to start dropping bits in the java stack and then slowly propagate all of that to the python bits).

jonrkarr commented 3 years ago

We don't intend to encourage people to use older versions. We just aim to help people use older published models.

pgleeson commented 3 years ago

Looks good.

jonrkarr commented 3 years ago

We can deploy this online when the next version is released.