pynml-modchananalysis excepting on division by zero

NeuroML / pyNeuroML

A single package in Python unifying scripts and modules for reading, writing, simulating and analysing NeuroML2/LEMS models.

https://docs.neuroml.org/Userdocs/Software/pyNeuroML.html

GNU Lesser General Public License v3.0

34 stars 30 forks source link

pynml-modchananalysis excepting on division by zero #216

Closed borismarin closed 1 year ago

borismarin commented 1 year ago

Fixes #202, #165

sanjayankur31 commented 1 year ago

I tested the pynml-modchanalysis change, and it works great. Tweaked our CI in #217 too.

I'll test the divide by zero bit with the file I was using in #202 and add a test for that tomorrow too.

sanjayankur31 commented 1 year ago

Another thought: to be sure that we're using the right value for platform etc., we could also get it directly from nrnivmodl by parsing/grepping the file to get the value of the ARCH variable?

pgleeson commented 1 year ago

Looks good to me!