Feat/issue 303: de-duplicate plot spikes code

[AdityaBITMESRA]

I have created a pull request with the necessary instructions.

[sanjayankur31]

Maybe reduce the size of the markers so we can see if they're being plotted at the right time?

Next---A LEMS file can include the spike data, but it is far more common for the LEMS file to point to an EventOutputFile that stores the spikes. So that'll be a proper test. See this example:

https://docs.neuroml.org/Userdocs/IzhikevichNetworkExample.html#simulating-the-model

(If you haven't been through these examples, it'll be good to do so. You do need to understand a little bit of how NeuroML/LEMS works)

[AdityaBITMESRA]

Hello sir @sanjayankur31 I have made the changes and this is the plot

[AdityaBITMESRA]

""" 
this was the lems file that I used

[sanjayankur31]

The plot looks good. Let me take a look at this today and get back to you.

[sanjayankur31]

Convention to follow:

• .dat files for time series
• .spikes files for spike data

[sanjayankur31]

We do need to infer the total number of cells in each output file

• when plotting output files, we can only infer based on the max cell id
• when plotting from lems files, we can read the model spec and get the total number of cells

[sanjayankur31]

Hi @AdityaBITMESRA , please drop a comment here when this is ready for another round of review.

Oh, and please pull in development to your branch to ensure you have the latest code from the other parts of the repo.

[AdityaBITMESRA]

Sure sir @sanjayankur31 I will keep this in my mind

[AdityaBITMESRA]

Sir @sanjayankur31 I have addressed all the comments. Can you give it a look?

[AdityaBITMESRA]

Thankyou for all the inputs

[sanjayankur31]

Thankyou for all the inputs

No problem, it's getting there, just a few tweaks. Well done so far!

(If anything is unclear, please feel free to ping me in the chat channel. I'm usually there all day from 0900 - 1800 London time on work days)

[AdityaBITMESRA]

okay sir

[sanjayankur31]

okay sir

Cool. Also, no need to refer to any of us as "sir" :)

[sanjayankur31]

When you want me to look at this @AdityaBITMESRA , please request another review (click the button next to my user in the review bit), or just drop me a comment here saying so---just so that I know that I should look at the PR again.

[AdityaBITMESRA]

Sure, I added the offset parameter and it is working correctly. Can you have a look at it

[sanjayankur31]

Cool, I'll do another round of review tomorrow.

[sanjayankur31]

Merged into https://github.com/NeuroML/pyNeuroML/tree/feat/issue-303-development

I'll make tweaks there and merge into development