search

NeuroTechX / EEG-ExPy

EEG Experiments in Python
https://neurotechx.github.io/EEG-ExPy/
BSD 3-Clause "New" or "Revised" License
420 stars 124 forks source link

switched back to python 3.7 #171

Closed JohnGriffiths closed 2 years ago

JohnGriffiths commented 2 years ago

Several issues with the current docs site. Need to solve this docs building issue, even if just a temporary fix, as we are (hoping for!) lots of eyes on this site right now.

AFAIK this has to be an iterative process of commit, check action status, commit, etc. Interactive prompt within gh actions would be handy, I don't know how to do that yet.

ErikBjare commented 2 years ago

The resulting error is one of the things I fixed in #167 by removing version locks: https://github.com/NeuroTechX/eeg-notebooks/pull/167/files#diff-4d7c51b1efe9043e44439a949dfd92e5827321b34082903477fd04876edb7552L48-R54

JohnGriffiths commented 2 years ago

ok thanks, I can add those back in here.

the version specs seem to be important for some libs that break with new version of dependencies. but that's likely not the case for most of our dependencies, and indeed the converse is also an issue, as we have here.

JohnGriffiths commented 2 years ago

woop woop we have a pass on docs build.

I vote to merge. @ErikBjare you agree?