search

NeuroTechX / EEG-ExPy

EEG Experiments in Python
https://neurotechx.github.io/EEG-ExPy/
BSD 3-Clause "New" or "Revised" License
420 stars 124 forks source link

Added FOOOF section on 01r_n170_viz #179

Open GiovanniChiarion opened 2 years ago

GiovanniChiarion commented 2 years ago

I added a new section of PSD parametrization using FOOOF algorithm proposed by Thomas Donoghue @TomDonoghue I hope it could be appreciated.

JohnGriffiths commented 2 years ago

Ciao Giovanni.

Thanks for this contribution.

This is a great idea.

A few requests before we can merge what you've done here:

  1. It would be better if the FOOOF analysis is done separately a stand-alone example, so there is sufficient space to explain what it's doing without over-complicating the existing examples.

  2. In that new example script, take the time to explain in the file comments what it is that you are plotting, and what they mean and your general interpretation of what you're observing.

Note, I think you need to add some plt.show() lines for all of the figures to appear when running the script on windows.

Best,

j

GiovanniChiarion commented 1 year ago

Sorry for the late reponse, I've done as you suggested and created a new example file (03r_n170_fooof.py) and reverted changes to the first example. I hope to haven't done too much messes with git. Let me know if everything is ok :)