NeuroTechX / EEG-ExPy

EEG Experiments in Python
https://neurotechx.github.io/EEG-ExPy/
BSD 3-Clause "New" or "Revised" License
418 stars 124 forks source link

visual p100 test #208

Closed pellet closed 1 year ago

pellet commented 1 year ago

Let me know of any thing I need to change, like consolidating this experiment with the existing VEP code before it can be merged. Thanks a lot for this great open source project.

JohnGriffiths commented 1 year ago

Hi Ben.

This looks great!

There's quite a lot of interesting pieces here. I was wondering if you would be able to join an eegnb developer's meeting to talk us through a bit? Our next one is 10am EST on Thurs 20th.

A few thoughts so far:

pellet commented 1 year ago

Hi John, thanks for the quick feedback. Yeah sure I'll try to join the next meeting to give an overview of the changes, I find running through pull requests over a video call a nice way to get people across changes. I'll take a look into dealing with points you've raised - I'll try getting across the experiment refactor and think how these changes will fit.

tmorshed commented 1 year ago

To fix the build issue, especially for the Docs build. As @oreHGA mentioned, seeems like adding pip install attrdict before the wxpython install line

pellet commented 1 year ago

This work will be added in a new PR after merging the vr support for the n170 experiment.