update dependencies - for build

NeuroTechX / EEG-ExPy

EEG Experiments in Python

https://neurotechx.github.io/EEG-ExPy/

BSD 3-Clause "New" or "Revised" License

418 stars 124 forks source link

update dependencies - for build #220

Closed oreHGA closed 1 year ago

tmorshed commented 1 year ago

docs builds fine now.
Turns out my fix yesterday was already good -- I was just not favoured by matplotlib RAM gods, and the figures were all coming out on top of one another.
new fig:
old fig:

seems good enough for now. will do visual improvements later.

tmorshed commented 1 year ago

@oreHGA I cannot assign you as reviewer since you are the main PR author. Can you please take a look at this?

It builds fine now. This example has some problems, specifically with legends and indexing (not just in the figure above), which I can come back to later. Needs more inspection. But I think it should be okay to merge with dev for now.

oreHGA commented 1 year ago

Thank you @tmorshed! Merged the changes to develop

NeuroTechX / EEG-ExPy

update dependencies - for build #220

old fig: