search

NeuroTechX / EEG-ExPy

EEG Experiments in Python
https://neurotechx.github.io/EEG-ExPy/
BSD 3-Clause "New" or "Revised" License
418 stars 124 forks source link

installation code updated (typo fixed) #235

Closed rmib200 closed 1 year ago

rmib200 commented 1 year ago

Example code to test installation on the documentation updated.

JohnGriffiths commented 1 year ago

@rmib200 I'm afraid you will need to close this PR and re-submit one again.

It looks like you've committed an entire folder that is filetree levels up from the source code ( build/lib/eegnb/... )

So it now looks like you've essentially re-added the entire file code base, and apart from the doc folders (which may be ok), we can't see the actual diffs that you've made.

You need to edit the files in the location they appear in the cloned repo. You shouldn't copy them over from another location.

Also, in general I recommend never commit entire folders or use the wildcard * when using git. Better to break it down into several small commits of files individually or in small groups, where the files are explicitly listed on the commit cmd, and give a specific comment on what it is that you've done.

Thanks for doing this - look forward to seeing the revised PR :)