search

NeuroTechX / bci-workshop

Material for the BCI Workshop held at District 3 in May 2015 by BCI Montréal.
Other
88 stars 55 forks source link

Octave #8

Closed rcassani closed 7 years ago

rcassani commented 7 years ago

Support is added for Octave 64-bit in Windows LIBSVM binaries are used for SVM functions in MATLAB and Octave Update in links, to point to NeurotechX GitHub

hubertjb commented 7 years ago

Some other comments from testing the Octave code on my machine:

Other than that, it's awesome, it worked straight away with Octave! :) Thanks @rcassani !!

rcassani commented 7 years ago
hubertjb commented 7 years ago

I see, that makes sense.

Le 2 avr. 2017 12:50, "Raymundo Cassani" notifications@github.com a écrit :

  • The x-axis limits will be explicitly set with xlim()
  • I'll check the closing and plotting behaviours in Octave. About closing both figures at the end is possible, however sometimes is useful to go back and see what happened, e.g. when running the scripts by yourself, to know what happened in the close-eyes segment. Also, all figures are closed when the scripts re-start.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NeuroTechX/bci-workshop/pull/8#issuecomment-290998486, or mute the thread https://github.com/notifications/unsubscribe-auth/AGMx-qvc5jdY-IcwCIY2L4W2HACbnPENks5rr9HJgaJpZM4Mc0Oc .

rcassani commented 7 years ago

@hubertjb , can you verify if the behaviour of duplicated plots in Octave is corrected? If that's the case, we should be ready to merge :collision:

hubertjb commented 7 years ago

@rcassani it works fine for exercise 1! I just realized that for exercise 2 you also need to type in q in the command window. Do you want to add that in the instruction string (something like "To stop exercise execution, close the decision figure window and press .")?

rcassani commented 7 years ago

The last commit should have fix that issue

hubertjb commented 7 years ago

Works perfectly! Ready to merge :)