search

NeuroTechX / eeg-notebooks_v0.1

Previous version of eeg-notebooks
https://neurotechx.github.io/eeg-notebooks
BSD 3-Clause "New" or "Revised" License
184 stars 56 forks source link

[WIP] - Kyle updates to add cueing and baseline tasks, cueing data set, cueing analysis tutorial #24

Closed kylemath closed 4 years ago

kylemath commented 4 years ago

Ok lets lay this all out and chat, since it looks like there are a few more general changes I have made, I will go through the files changed and comment specifically,

the number is big @JohnGriffiths since I am including a dataset for the cueing task

JohnGriffiths commented 4 years ago

Epic work Kyle. Great stuff.

Please take a close look at everything after the merge and confirm nothing was broken as soon as you're able.

kylemath commented 4 years ago

I don't think you should have merged that sorry might want to revert May break people's tasks havnt tested everything

On Sat., Mar. 14, 2020, 10:09 a.m. John Griffiths, notifications@github.com wrote:

Merged #24 https://github.com/NeuroTechX/eeg-notebooks/pull/24 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NeuroTechX/eeg-notebooks/pull/24#event-3129537483, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA36GFMT6Q674GHDIWVBC63RHOT4DANCNFSM4LHPUAXQ .

JohnGriffiths commented 4 years ago

I looked through - the changes look like almost entirely new additions.

Which pre-existing files specifically do you think could be adversely affected?