search

NeuroTechX / moabb

Mother of All BCI Benchmarks
https://neurotechx.github.io/moabb/
BSD 3-Clause "New" or "Revised" License
646 stars 167 forks source link

Download link broken braininvaders #505

Open PierreGtch opened 8 months ago

PierreGtch commented 8 months ago 
ERROR: test_data_path (moabb.tests.datasets.Test_VirtualReality_Dataset)
No hdf5_path provided, models will not be saved.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/moabb/moabb/moabb/tests/datasets.py", line 313, in test_data_path
    data_path = ds.data_path(1)
  File "/home/runner/work/moabb/moabb/moabb/datasets/braininvaders.py", line 904, in data_path
    return _bi_data_path(self, subject, path, force_update, update_path, verbose)
  File "/home/runner/work/moabb/moabb/moabb/datasets/braininvaders.py", line 405, in _bi_data_path
    file_path = dl.data_path(url, "VIRTUALREALITY")
  File "<decorator-gen-648>", line 12, in data_path
  File "/home/runner/work/moabb/moabb/moabb/datasets/download.py", line 101, in data_path
    retrieve(url, None, path=destination)
  File "/home/runner/work/moabb/moabb/.venv/lib/python3.8/site-packages/pooch/core.py", line 239, in retrieve
    stream_download(url, full_path, known_hash, downloader, pooch=None)
  File "/home/runner/work/moabb/moabb/.venv/lib/python3.8/site-packages/pooch/core.py", line 803, in stream_download
    downloader(url, tmp, pooch)
  File "/home/runner/work/moabb/moabb/.venv/lib/python3.8/site-packages/pooch/downloaders.py", line 207, in __call__
    response.raise_for_status()
  File "/home/runner/work/moabb/moabb/.venv/lib/python3.8/site-packages/requests/models.py", line 1021, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 503 Server Error: Service Temporarily Unavailable for url: https://zenodo.org/record/2605205/files/subject_01_VR.mat

----------------------------------------------------------------------

and

ERROR: test_data_path (moabb.tests.datasets.Test_VirtualReality_Dataset)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/moabb/moabb/moabb/tests/datasets.py", line 313, in test_data_path
    data_path = ds.data_path(1)
  File "/home/runner/work/moabb/moabb/moabb/datasets/braininvaders.py", line 904, in data_path
    return _bi_data_path(self, subject, path, force_update, update_path, verbose)
  File "/home/runner/work/moabb/moabb/moabb/datasets/braininvaders.py", line 405, in _bi_data_path
    file_path = dl.data_path(url, "VIRTUALREALITY")
  File "<decorator-gen-644>", line 12, in data_path
  File "/home/runner/work/moabb/moabb/moabb/datasets/download.py", line 101, in data_path
    retrieve(url, None, path=destination)
  File "/home/runner/work/moabb/moabb/.venv/lib/python3.8/site-packages/pooch/core.py", line 239, in retrieve
    stream_download(url, full_path, known_hash, downloader, pooch=None)
  File "/home/runner/work/moabb/moabb/.venv/lib/python3.8/site-packages/pooch/core.py", line 803, in stream_download
    downloader(url, tmp, pooch)
  File "/home/runner/work/moabb/moabb/.venv/lib/python3.8/site-packages/pooch/downloaders.py", line 207, in __call__
    response.raise_for_status()
  File "/home/runner/work/moabb/moabb/.venv/lib/python3.8/site-packages/requests/models.py", line 1021, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 500 Server Error: INTERNAL SERVER ERROR for url: https://zenodo.org/record/2605205/files/subject_01_VR.mat

----------------------------------------------------------------------
sylvchev commented 8 months ago

This is only occuring in CI: for example, https://zenodo.org/record/2605205/files/subject_01_VR.mat is a working link and using Cattan2019_VR(virtual_reality=True, screen_display=True).data_path(1) is working on my laptop. I'll commenting out the data_path test in the CI, as I prefer to avoid making some download inside unit test. For the documentation, I'll propose to comment the example with VR for now and to include it again when this will be solved.

sylvchev commented 8 months ago

See #502

Tracking down differences in updated package with this PR, urllib3 is the only one that was upgraded between this PR and previous ones (no version change in pooch, request or oath). The version of urllib raised from 1. to 2. I'm trying to solve this by pinning version of urllib3 to version <= 2.0, it is temporary but I could not find any issue related to this on upstream. We need to identify the bug and/or report it upstream (to urllib3)