search

NeuroTechX / moabb

Mother of All BCI Benchmarks
https://neurotechx.github.io/moabb/
BSD 3-Clause "New" or "Revised" License
646 stars 168 forks source link

Try fix workflow #584

Open PierreGtch opened 2 months ago

bruAristimunha commented 2 months ago

This issue is different! Sensational!

If you have time, can you take look on the secret on the neurotechx organization @sylvchev? Maye someone outside of the moabb project may have updated it on neurotechx and we didn't see it.

PierreGtch commented 2 months ago

Yes, the idea is to have the git sha of the HEAD written somewhere in the generated HTML files so that we are sure that there is always a difference between two pushes to the gh pages repo.

PierreGtch commented 2 months ago

Why are we not using actions/cache/restore@v3 to get the build cache here: https://github.com/NeuroTechX/moabb/blob/29c04234bc17af807a73f9cfdecfc1b995281efa/.github/workflows/docs.yml#L112

See here: https://github.com/actions/cache/blob/v3.3.3/caching-strategies.md#make-cache-read-only--reuse-cache-from-centralized-job

PierreGtch commented 2 months ago

Why is the cache named "Cache datasets and docs"? I don't see where we are caching the datasets

PierreGtch commented 2 months ago

I think we should use a "short lived cache" for the docs build: https://github.com/actions/cache/blob/v3.3.3/caching-strategies.md#creating-a-short-lived-cache

Otherwise there might be interactions between different workflow runs

bruAristimunha commented 2 months ago

Hey @PierreGtch!

I tried something because I wanted to see if you work. You can revert if it does not work. I gave you admin permission to access the moabb secret keys. This could help the GitHub.io deployment.

I don't have permission from the organization NeuroTechX, so we need to wait for @sylvchev

alexfigtree commented 2 weeks ago

@bruAristimunha Could you please fix the job errors caused by your recent PR: https://github.com/NeuroTechX/moabb/pull/609 (specifically https://github.com/NeuroTechX/moabb/pull/609/commits/dc51ddbc4bde5a26bbb3b6c28f3908111ba250d3). Let me know if a new issue should be opened for it.

bruAristimunha commented 2 weeks ago

Hey @alexfigtree,

I'm not seeing the relationship between this commit and this PR. Can you elaborate please?

alexfigtree commented 2 weeks ago

@bruAristimunha Your commit here is causing all subsequent build jobs to fail and has gone unaddressed, please fix, and open a separate issue if needed. Screenshot 2024-06-14 at 4 44 57 PM

bruAristimunha commented 2 weeks ago

Sorry @alexfigtree, but it is not related... The issue is related to deployment to the webpage. It is not affecting the software.

This error is quite old, more than 1 year old, and we were unable to resolve it and this PR is an attempt to refactor how we deploy.

If you want to be more involved in moabb maintenance, we can join you in the weekly meeting where we discuss the library. Ping me if you are interested, I am on neurotechx slack.

alexfigtree commented 2 weeks ago

@bruAristimunha Yes, I know it's not related, but GitHub does not make it easy for me to message you directly without tagging you in preexisting work. I'm currently maintaining the GH org for NTX, so am in the process of cleaning up repos to make the projects more accessible for future collaborators. Yes, please send me an invite to your meetings.