Open tahatt13 opened 3 weeks ago
tahatt13
commented
3 weeks ago | The dataset includes data from 50 acute stroke patients, and it involves two motor imagery tasks: right-handed and left-handed movements. Here are more details about the dataset : | Name | #Subj | #Chan | #Classes | #Trials / class | Trials len | Sampling rate | #Sessions |
|---|---|---|---|---|---|---|---|---|
| Liu2024 | 50 | 30 EEG | 2 | 40 | 4 sec | 500 Hz | 1 |
bruAristimunha
commented
2 weeks ago The question here is: is this dataset good enough to be merged?
bruAristimunha
commented
2 weeks ago Hey @sebVelut!
Can you please review this code by next Friday? A shallow review is good!
sebVelut
commented
1 week ago Hi ! I have reviewed and tested it by getting data with paradigm.get_data() and by testing WithinSessionEvaluation with a Xdawn + TS + LDA and everything worked without problems. The code seems good in my point of view.
But I think you should be careful about the events id described as said by Bruno, it should be the same as in the mapping. Moreover, the use of annotations seems to work, another idea is to use a stim channel (or transform the existing one) and put the label of the events as value of the channel. Then the moabb will search for the stim channel first (this method seems to be taken by several other dataset implementation, ex: Physionet_mi or mpi_mi). Up to you if you decide to change the method.
A last point, in whats_new.rst, it is missing the line to say that you have added the Liu dataset