search

NeuroTechX / moabb

Mother of All BCI Benchmarks
https://neurotechx.github.io/moabb/
BSD 3-Clause "New" or "Revised" License
646 stars 168 forks source link

Fixed url to Lee2019 #621

Closed toncho11 closed 3 weeks ago

toncho11 commented 3 weeks ago

Closes #616

bruAristimunha commented 3 weeks ago

Can you solve Cho dataset too @toncho11?

https://github.com/NeuroTechX/moabb/blob/develop/moabb%2Fdatasets%2Fgigadb.py#L16

toncho11 commented 3 weeks ago

Can you solve Cho dataset too @toncho11?

https://github.com/NeuroTechX/moabb/blob/develop/moabb%2Fdatasets%2Fgigadb.py#L16

What is the problem with Cho 2017? Are you unable to download it?

bruAristimunha commented 3 weeks ago

Same problem I think, they were hosted in the same place

toncho11 commented 3 weeks ago

Same problem I think, they were hosted in the same place

You mean you did not test. Cho 2017 is actually on https even if the name of the server starts with "ftp": GIGA_URL = "https://ftp.cngb.org/pub/gigadb/pub/10.5524/100001_101000/100295/mat_data/"

I did a quick test and I do not think that there is a problem with Cho 2017. Please test as well to confirm that there is no problem.

But if they are also hosted on the same server as Lee, the url should be:

https://s3.ap-northeast-1.wasabisys.com/gigadb-datasets/live/pub/10.5524/100001_101000/100295/mat_data/

sylvchev commented 3 weeks ago

I'll check this