search

NeuroTechX / moabb

Mother of All BCI Benchmarks
https://neurotechx.github.io/moabb/
BSD 3-Clause "New" or "Revised" License
701 stars 181 forks source link

Deprecated the deep learning model #660

Open bruAristimunha opened 1 month ago

bruAristimunha commented 1 month ago

We have put a lot of effort into building a deep learning module, but clearly, this is not the best environment to maintain a deep learning library. I am proposing to deprecate the entire deep learning module and keep only the support for braindecode.

Currently, everything is already integrated into braindecode (EEGNeX, shallow, deep, eegnet and eegtcn), and it does not make much sense to have duplicate code.

Before officially removing the code duplication, a comparative study should be done and approved.

cc. @sylvchev and @carraraig

bruAristimunha commented 1 month ago

cc. @tomMoral too

carraraig commented 1 month ago

Hi @bruAristimunha ! I think on my side is the direction to go, since brain decode is well maintained. However I think can be useful to keep the current implementation in Tensorflow in order to ensure the full replicability of the MOABB benchmark. Maybe we can keep them in a separated folder. What do you think?

PierreGtch commented 1 month ago

Even if we remove it, the benchmark will be replicable by using the correct release. Maybe we could simply add a tag in the repo on the commit people should use to replicate this benchmark?