NeurodataWithoutBorders / lindi

Linked Data Interface (LINDI) - cloud-friendly access to NWB data
BSD 3-Clause "New" or "Revised" License
5 stars 1 forks source link

exclude zattrs when empty #16

Closed magland closed 8 months ago

magland commented 8 months ago

Addresses #15

With this, .zattrs is now excluded in the reference file system. However...

I felt it wasn't worth the overhead of determining whether attrs are empty in the __contains__ function, especially since we are adding additional special attributes here and there. So, in the LindiH5Store, the file is still always present. But in the exported reference file system (where this matters more), it is excluded - because that's a much easier check. See notes in source code.

This PR also makes some fixes to the __contains__ function and adds some asserts to the tests.