NeurodataWithoutBorders / lindi

Linked Data Interface (LINDI) - cloud-friendly access to NWB data
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Proposed simplification: remove support for wrapping h5py in LindiH5pyFile #48

Closed magland closed 5 months ago

magland commented 5 months ago

Right now LindiH5pyFile can either wrap a zarr object or an h5py object. This leads to a lot of if/else checks throughout the code. For example

        if isinstance(self._group_object, h5py.Group):
            ...
        elif isinstance(self._group_object, zarr.Group):
            ....
        else:
            raise Exception(f"Unhandled type: {type(self._group_object)}")

Initially, my reason for supporting both was a matter of testing/debugging. The h5py case is not used in any of the use cases. This would greatly simplify the codebase.

@rly what do you think?

magland commented 5 months ago

spoke ryan, we're going ahead with this.