search

NeurodataWithoutBorders / lindi

Linked Data Interface (LINDI) - cloud-friendly access to NWB data
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

remove case of LindiH5pyFile wrapping h5py.File #52

Closed magland closed 2 months ago

magland commented 2 months ago

As discussed with Ryan.

For now this is set to merge into dev5 which contains some other pending PRs. Will switch to base of main once those are merged.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 78.89908% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 83.42%. Comparing base (5cd5d6f) to head (9882980).

Files Patch % Lines
...indi/LindiH5pyFile/writers/LindiH5pyGroupWriter.py 41.66% 7 Missing :warning:
lindi/LindiH5pyFile/LindiH5pyAttributes.py 76.47% 4 Missing :warning:
lindi/LindiH5pyFile/LindiH5pyGroup.py 87.09% 4 Missing :warning:
lindi/LindiH5pyFile/LindiH5pyDataset.py 89.65% 3 Missing :warning:
lindi/LindiH5pyFile/LindiH5pyFile.py 76.92% 3 Missing :warning:
...di/LindiH5pyFile/writers/LindiH5pyDatasetWriter.py 60.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #52 +/- ## ========================================== + Coverage 82.59% 83.42% +0.83% ========================================== Files 28 28 Lines 2005 1907 -98 ========================================== - Hits 1656 1591 -65 + Misses 349 316 -33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.