search

NeurodataWithoutBorders / lindi

Linked Data Interface (LINDI) - cloud-friendly access to NWB data
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

write to local lindi json file (3) #57

Closed magland closed 2 months ago

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 71.73913% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 79.96%. Comparing base (40959a2) to head (2de0799).

Files Patch % Lines
lindi/LindiH5pyFile/LindiH5pyFile.py 71.73% 26 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## copy-chunks-to-staging-area #57 +/- ## =============================================================== - Coverage 80.43% 79.96% -0.47% =============================================================== Files 29 29 Lines 2131 2151 +20 =============================================================== + Hits 1714 1720 +6 - Misses 417 431 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

magland commented 2 months ago

The goal here is to rearrange things a bit so that we can open .lindi.json file in write modes ("r+", "w", "w-", "x", "a") in the same way that we would open a .h5 file for writing. We don't want to be completely rewriting the .json file with each change... so instead we only rewrite it when flush() is called (which is an h5py function)... and note that flush() is also called when the file is closed (including when it goes out of context).

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 71.87500% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 79.97%. Comparing base (833b3f3) to head (0ea4fb0).

Files Patch % Lines
lindi/LindiH5pyFile/LindiH5pyFile.py 71.73% 26 Missing :warning:
...ndi/LindiH5pyFile/LindiReferenceFileSystemStore.py 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## copy-chunks-to-staging-area #57 +/- ## =============================================================== - Coverage 80.45% 79.97% -0.48% =============================================================== Files 29 29 Lines 2133 2157 +24 =============================================================== + Hits 1716 1725 +9 - Misses 417 432 +15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.