search

NeurodataWithoutBorders / lindi

Linked Data Interface (LINDI) - cloud-friendly access to NWB data
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

implement lindi.File, drop-in replacement for h5py.File that supports .lindi.json files based on extension (4) #60

Closed magland closed 2 months ago

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 78.94737% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 81.47%. Comparing base (3b08289) to head (089b6ee). Report is 1 commits behind head on write-json.

Files Patch % Lines
lindi/File/File.py 88.88% 2 Missing :warning:
lindi/LindiH5ZarrStore/LindiH5ZarrStore.py 50.00% 2 Missing :warning:
lindi/LindiH5pyFile/LindiH5pyFile.py 71.42% 2 Missing :warning:
lindi/LindiStagingStore/StagingArea.py 75.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## write-json #60 +/- ## ============================================== + Coverage 79.95% 81.47% +1.52% ============================================== Files 29 30 +1 Lines 2155 2208 +53 ============================================== + Hits 1723 1799 +76 + Misses 432 409 -23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

magland commented 2 months ago

Here we make a lindi.File that can be a drop-in replacement for h5py.File, where it smartly decides whether to use h5py or lindi based on the file extension of the file name.

This PR corrects a few small issues/mistakes from previous PRs.