search

NeurodataWithoutBorders / lindi

Linked Data Interface (LINDI) - cloud-friendly access to NWB data
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Add generation metadata to .lindi.json file writing (6) #63

Closed magland closed 2 months ago

magland commented 2 months ago

self explanatory

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.30%. Comparing base (ca0a390) to head (fe8a5c5).

Files Patch % Lines
lindi/LindiH5pyFile/LindiH5pyFile.py 33.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## catch-chunk-byte-range-error #63 +/- ## ================================================================ - Coverage 81.38% 81.30% -0.08% ================================================================ Files 30 30 Lines 2186 2188 +2 ================================================================ Hits 1779 1779 - Misses 407 409 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rly commented 2 months ago

This looks OK to me. Could you add to the write_lindi_file docstring and to the docstring of LindiReferenceFileSystemStore which describes the format of the RFS dict/file.

magland commented 2 months ago

This looks OK to me. Could you add to the write_lindi_file docstring and to the docstring of LindiReferenceFileSystemStore which describes the format of the RFS dict/file.

done.