Closed rly closed 6 months ago
Attention: Patch coverage is 50.00000%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 81.35%. Comparing base (
1fc62ef
) to head (e50931b
).
Files | Patch % | Lines |
---|---|---|
lindi/LindiH5pyFile/LindiH5pyFile.py | 50.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I would like to download a remote HDF5 file and create a lindi file with references to the remote location using the downloaded local HDF5 file. I think creating such a lindi file using a remote HDF5 file would take longer than downloading the file and creating such a lindi file using the downloaded local HDF5 file, but I am not sure.
LindiH5ZarrStore.from_file
lets you create a store using a local file with references to the remote location: https://github.com/NeurodataWithoutBorders/lindi/blob/1fc62ef070b9cb545704f69a71dad26acbdb6f7f/lindi/LindiH5ZarrStore/LindiH5ZarrStore.py#L69LindiH5pyFile.from_hdf5_file
callsLindiH5ZarrStore.from_file
but does not let the user set the remote location to a location different from the file location: https://github.com/NeurodataWithoutBorders/lindi/blob/1fc62ef070b9cb545704f69a71dad26acbdb6f7f/lindi/LindiH5pyFile/LindiH5pyFile.py#L61This PR exposes the
url
keyword argument inLindiH5ZarrStore.from_file
toLindiH5pyFile.from_hdf5_file
to allow those two locations to be different. The docstring is copied fromLindiH5ZarrStore.from_file
and modified.@magland please confirm that the last sentence of the docstring for
url
is still valid.