search

NeurodataWithoutBorders / matnwb

A Matlab interface for reading and writing NWB files
BSD 2-Clause "Simplified" License
49 stars 32 forks source link

update paths #173

Closed bendichter closed 4 years ago

bendichter commented 4 years ago

generateCore currently expects paths schema/core/nwb.namespace.yaml and schema/common/namespace.yaml.

git clone https://github.com/NeurodataWithoutBorders/nwb-schema.git

creates filepath nwb-schema/core/nwb.namespace.yaml and the core is missing because you need to call git clone in recursive mode. If you correct that, calling instead

git clone --recursive https://github.com/NeurodataWithoutBorders/nwb-schema.git

you also get path nwb-schema/hdmf-common-schema/common/namespace.yaml. In order to update our code to the current schema, we need to

  1. Change the git clone call to be recursive
  2. Update the filepaths in generateCore
bendichter commented 4 years ago

We could also do what pynwb does and attach nwb-schema as a submodule at a specific commit. What do you think of that, @ln-vidrio

lawrence-mbf commented 4 years ago

The only hangup against moving to submodules is that users who are using git to manage matnwb must know that submodules now exist, otherwise their schemas will never actually be updated. I have no idea how many users are actually using this method though.