Closed tekriwal closed 3 years ago
Ah, part of this is that schema version 2.1.0
is not present as a schema option. The other is actually a bug in the dtype not supported float
types as it should. I will follow up this ticket with updates for the two issues.
float
discrepancy.Great, trying it now!
Best, Andy Tekriwal 609-276-1076
On Tue, Nov 16, 2021 at 1:07 PM ln-vidrio @.***> wrote:
344 https://github.com/NeurodataWithoutBorders/matnwb/pull/344 has
added 2.1.0 as a valid schema which has now been merged so re-downloading from the Github repository should . Working on the float discrepancy.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NeurodataWithoutBorders/matnwb/issues/343#issuecomment-970636862, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECIJAH5XHRXL7CONSLJF6TUMK2WRANCNFSM5IE6RJLQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Ah, sorry. You will most likely receive the same error because the float
discrepancy is the error message we're seeing in the ticket.
Yeah, still getting error. Wasn't sure if I was doing something wrong on my end though so thanks for letting me know. Is there anything I can do on my end to help or wait to hear back when a change is pushed?
Best, Andy Tekriwal 609-276-1076
On Tue, Nov 16, 2021 at 1:25 PM ln-vidrio @.***> wrote:
Ah, sorry. You will most likely receive the same error because the float discrepancy is the error message we're seeing in the ticket.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NeurodataWithoutBorders/matnwb/issues/343#issuecomment-970650164, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECIJAGI5LN4S4AUHDP7XIDUMK42HANCNFSM5IE6RJLQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
I'm currently waiting on #345 's tests to finish. Once that finishes I can let you know that you can test it.
Thank you!
Best, Andy Tekriwal 609-276-1076
On Tue, Nov 16, 2021 at 1:49 PM ln-vidrio @.***> wrote:
I'm currently waiting on #345 https://github.com/NeurodataWithoutBorders/matnwb/pull/345 's tests to finish. Once that finishes I can let you know that you can test it.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NeurodataWithoutBorders/matnwb/issues/343#issuecomment-970667024, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECIJACOODMN2KVJCYH35YTUMK7XBANCNFSM5IE6RJLQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
That is done, when you find the time let me know if the new main branch works.
Cool! I am good to go, thank you.
Should I mark the issue resolved or something on me end?
Best, Andy Tekriwal 609-276-1076
On Tue, Nov 16, 2021 at 2:19 PM ln-vidrio @.***> wrote:
That is done, when you find the time let me know if the new main branch works.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NeurodataWithoutBorders/matnwb/issues/343#issuecomment-970687796, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECIJAGFIO3HG6I7CK3N3X3UMLDFVANCNFSM5IE6RJLQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
I can do that.
Error in types.util.correctType (line 57) prefix = typeMatch{1};
Error in types.core.AnnotationSeries (line 10) varargin = [{'comments' 'no comments' 'data_conversion' types.util.correctType(1, 'float32') 'data_resolution' types.util.correctType(-1, 'float') 'data_unit' 'n/a' 'description' 'no description'} varargin];
Error in io.parseGroup (line 85) parsed = eval([Type.typename '(kwargs{:})']);
Error in io.parseGroup (line 38) subg = io.parseGroup(filename, group, Blacklist);
Error in io.parseGroup (line 38) subg = io.parseGroup(filename, group, Blacklist);
Error in nwbRead (line 45) nwb = io.parseGroup(filename, h5info(filename), Blacklist);
%%%%%%%%%
%as requested, see below for output from schema check util.getSchemaVersion(fullfile('/Users','andytekriwal','Box','EMU','STUDY_PDIL',ptPlaceholder, 'SEEG', 'processed', ephysfilename)) ans = '2.1.0'