NeurodataWithoutBorders / matnwb

A Matlab interface for reading and writing NWB files
BSD 2-Clause "Simplified" License
49 stars 32 forks source link

[Feature]: Use branch protections to avoid commits to the main branch #426

Closed oruebel closed 2 years ago

oruebel commented 2 years ago

What would you like to see added to MatNWB?

I noticed that the main branch currently does not have any protections set up. We should setup branch protections here https://github.com/NeurodataWithoutBorders/matnwb/settings/branches to make sure that changes to master are only permitted via PRs. We are using the same practice of permitting commits to the main branch only via PRs also for most other NWB repos. I'm happy to help with those changes, but I didn't want to cause any trouble in development by changing repo settings without checking here first.

Is your feature request related to a problem?

I was able to accidentally commit the changes I proposed in https://github.com/NeurodataWithoutBorders/matnwb/pull/425 directly to master. I reverted those changes, but ideally we should not permit commits directly to master to ensure that all changes are reviewed in PRs/

What solution would you like?

Add branch protections via https://github.com/NeurodataWithoutBorders/matnwb/settings/branches

Do you have any interest in helping implement the feature?

Yes.

Code of Conduct

lawrence-mbf commented 2 years ago

master Branch protections are now set for everyone, including administrators.