Closed lawrence-mbf closed 1 year ago
Merging #495 (9382c12) into master (8879f01) will increase coverage by
0.32%
. The diff coverage is89.51%
.
@@ Coverage Diff @@
## master #495 +/- ##
==========================================
+ Coverage 87.25% 87.58% +0.32%
==========================================
Files 128 129 +1
Lines 5250 5340 +90
==========================================
+ Hits 4581 4677 +96
+ Misses 669 663 -6
Impacted Files | Coverage Δ | |
---|---|---|
+file/Attribute.m | 100.00% <ø> (ø) |
|
+file/Dataset.m | 97.26% <ø> (ø) |
|
+file/Link.m | 100.00% <ø> (ø) |
|
+types/+util/checkConstraint.m | 66.66% <61.53%> (+16.66%) |
:arrow_up: |
+types/+util/parseConstrained.m | 67.74% <67.74%> (-32.26%) |
:arrow_down: |
+file/fillValidators.m | 78.14% <83.22%> (+8.65%) |
:arrow_up: |
+tests/+unit/multipleConstrainedTest.m | 95.00% <95.00%> (ø) |
|
+file/Group.m | 97.10% <96.15%> (+2.10%) |
:arrow_up: |
+file/fillConstructor.m | 96.32% <96.32%> (+0.63%) |
:arrow_up: |
+file/fillProps.m | 95.83% <97.10%> (+0.75%) |
:arrow_up: |
... and 7 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Thanks for the quick fix, @lawrence-mbf !
The changes in the MatNWB code generation code are beyond my expertise, so I defer to @bendichter for his review. I can attest that my test code works using this branch and that the code generated from generateCore
for validation of NWBFile acquisition, analysis, scratch, and stimulus_templates look correct.
Sounds good to me!
Motivation
Fix #494
How to test the behavior?
494 should not throw its error.
Checklist
fix #XX
whereXX
is the issue number?