Fix missing ids and columns in Intracellular Recordings Tables

NeurodataWithoutBorders / matnwb

A Matlab interface for reading and writing NWB files

BSD 2-Clause "Simplified" License

49 stars 32 forks source link

Fix missing ids and columns in Intracellular Recordings Tables #520

Closed lawrence-mbf closed 11 months ago

lawrence-mbf commented 11 months ago

Fixes #519

Motivation

ICephys file should pass nwbinspector

How to test the behavior?

https://github.com/NeurodataWithoutBorders/matnwb/issues/519#issuecomment-1650169048

Checklist

[x] Have you ensured the PR description clearly describes the problem and solutions?
[x] Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
[x] If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

lawrence-mbf commented 11 months ago

@oruebel The changes are on lines 49-61 of the live script. Feel free to make changes you feel are necessary for your talks.

codecov[bot] commented 11 months ago

Codecov Report

Merging #520 (a623d8f) into master (461c5c4) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #520   +/-   ##
=======================================
  Coverage   87.89%   87.89%           
=======================================
  Files         129      129           
  Lines        5461     5461           
=======================================
  Hits         4800     4800           
  Misses        661      661

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more