NeurodataWithoutBorders / matnwb

A Matlab interface for reading and writing NWB files
BSD 2-Clause "Simplified" License
49 stars 32 forks source link

Allow string inputs for most interfaces #522

Closed lawrence-mbf closed 11 months ago

lawrence-mbf commented 11 months ago

Fixes #287

Motivation

Allow for strings since these may be used by users.

How to test the behavior?

Using any of the generateCore, generateExtension, nwbRead, or nwbExport with double-quotes instead of single quotes should not cause errors.

Checklist

codecov[bot] commented 11 months ago

Codecov Report

Merging #522 (f48a5d6) into master (461c5c4) will decrease coverage by 0.05%. The diff coverage is 84.12%.

@@            Coverage Diff             @@
##           master     #522      +/-   ##
==========================================
- Coverage   87.89%   87.84%   -0.05%     
==========================================
  Files         129      129              
  Lines        5461     5489      +28     
==========================================
+ Hits         4800     4822      +22     
- Misses        661      667       +6     
Files Changed Coverage Δ
nwbExport.m 55.55% <55.55%> (-15.88%) :arrow_down:
nwbRead.m 79.38% <80.85%> (+0.49%) :arrow_up:
generateExtension.m 90.32% <90.32%> (-2.54%) :arrow_down:
generateCore.m 95.45% <95.45%> (+0.21%) :arrow_up:
+types/+untyped/DataStub.m 95.15% <100.00%> (+0.08%) :arrow_up:
+types/+untyped/ExternalLink.m 95.77% <100.00%> (+0.25%) :arrow_up:
+types/+untyped/ObjectView.m 88.00% <100.00%> (+1.04%) :arrow_up:
+types/+untyped/SoftLink.m 91.42% <100.00%> (+0.80%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more