NeurodataWithoutBorders / matnwb

A Matlab interface for reading and writing NWB files
BSD 2-Clause "Simplified" License
49 stars 32 forks source link

Fix multidimensional equality checks for arrays #524

Closed lawrence-mbf closed 11 months ago

lawrence-mbf commented 11 months ago

Fixes #487

Motivation

A cleaner redo instead of coercing the type's shape.

How to test the behavior?

1) Set up a valid FeatureExtraction Object 2) set its features property to some randomized value 3) All values of any type should pass. single typed values should not be converted.

Checklist

codecov[bot] commented 11 months ago

Codecov Report

Merging #524 (98d70e4) into master (0d334ed) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #524   +/-   ##
=======================================
  Coverage   87.84%   87.84%           
=======================================
  Files         129      129           
  Lines        5489     5489           
=======================================
  Hits         4822     4822           
  Misses        667      667           
Files Changed Coverage Δ
+types/+util/correctType.m 90.47% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more