NeurodataWithoutBorders / matnwb

A Matlab interface for reading and writing NWB files
BSD 2-Clause "Simplified" License
50 stars 32 forks source link

Replace and Update Datetime Parser #525

Closed lawrence-mbf closed 1 year ago

lawrence-mbf commented 1 year ago

Fixes #512

Motivation

To replace and update the datetime parser so it can be generalized following #512

How to test the behavior?

Reading and writing NWB files should be sufficient as they all need to update their file_create_date properties.

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #525 (db1a6d3) into master (601ee60) will decrease coverage by 0.24%. The diff coverage is 84.86%.

@@            Coverage Diff             @@
##           master     #525      +/-   ##
==========================================
- Coverage   87.84%   87.61%   -0.24%     
==========================================
  Files         129      130       +1     
  Lines        5489     5537      +48     
==========================================
+ Hits         4822     4851      +29     
- Misses        667      686      +19     
Files Changed Coverage Δ
+io/timestamp2datetime.m 68.96% <68.96%> (ø)
+types/+util/correctType.m 92.94% <92.94%> (+2.46%) :arrow_up:
+io/mapData2H5.m 97.77% <100.00%> (+0.15%) :arrow_up:
+tests/+unit/dataStubTest.m 98.43% <100.00%> (-0.07%) :arrow_down:
+tests/+util/verifyContainerEqual.m 100.00% <100.00%> (ø)
+types/+untyped/DataStub.m 95.59% <100.00%> (+0.44%) :arrow_up:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more