NeurodataWithoutBorders / matnwb

A Matlab interface for reading and writing NWB files
BSD 2-Clause "Simplified" License
49 stars 32 forks source link

Check Component Order #530

Closed lawrence-mbf closed 11 months ago

lawrence-mbf commented 11 months ago

Motivation

Fixes #526

How to test the behavior?

1) Create a TimeSeries 2) Reference the TimeSeries in one row of TimeIntervals timeseries 3) export the file and run nwbinspector

There should not be a weird indexing-related hdmf error. Ideally, MATLAB show throw the error before the file is written.

Checklist

codecov[bot] commented 11 months ago

Codecov Report

Merging #530 (bbf83ef) into master (d8c7d71) will increase coverage by 0.03%. The diff coverage is 91.40%.

@@            Coverage Diff             @@
##           master     #530      +/-   ##
==========================================
+ Coverage   87.67%   87.71%   +0.03%     
==========================================
  Files         132      132              
  Lines        5550     5584      +34     
==========================================
+ Hits         4866     4898      +32     
- Misses        684      686       +2     
Files Changed Coverage Δ
+io/mapData2H5.m 95.74% <66.66%> (-2.04%) :arrow_down:
+file/mapType.m 94.28% <84.61%> (ø)
+types/+util/checkDtype.m 86.66% <89.33%> (+3.33%) :arrow_up:
+file/fillConstructor.m 96.35% <100.00%> (+0.02%) :arrow_up:
+file/fillExport.m 98.72% <100.00%> (+0.01%) :arrow_up:
+io/writeAttribute.m 85.00% <100.00%> (+0.78%) :arrow_up:
NwbFile.m 82.85% <100.00%> (+0.12%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more