NeurodataWithoutBorders / matnwb

A Matlab interface for reading and writing NWB files
BSD 2-Clause "Simplified" License
50 stars 32 forks source link

Actually exit the function if dataset is not resizable #551

Closed lawrence-mbf closed 11 months ago

lawrence-mbf commented 11 months ago

Motivation

H5D might actually still fail even if a warning is emitted. Should actually exit to not risk breaking writes since we shouldn't be writing anyway.

How to test the behavior?

Attempt to modify a pynwb-generated file. You might (or might not) actually encounter the error with /file_create_date

Checklist

codecov[bot] commented 11 months ago

Codecov Report

Merging #551 (9177afe) into master (5d813aa) will decrease coverage by 0.05%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #551      +/-   ##
==========================================
- Coverage   87.82%   87.78%   -0.05%     
==========================================
  Files         132      132              
  Lines        5628     5631       +3     
==========================================
  Hits         4943     4943              
- Misses        685      688       +3     
Files Coverage Δ
+io/writeDataset.m 83.33% <83.33%> (-7.58%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more