Closed ehennestad closed 4 months ago
@ehennestad This is not kosher but could you apply the fix mentioned in here: https://github.com/NeurodataWithoutBorders/matnwb/issues/262#issuecomment-1923619681 as most of the errors in these tests come from there.
The failed test is actually a good sign!
Error using types.core/ElectricalSeries/validate_data_unit Unable to set the 'data_unit' property of class '<a href="matlab:doc types.core.ElectricalSeries">ElectricalSeries</a>' because it is read-only.
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
9d77234
) 88.49% compared to head (d8d18f0
) 88.52%.
Files | Patch % | Lines |
---|---|---|
+file/fillValidators.m | 95.83% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Motivation
Some schema attributes are redefined to be readonly for inherited classes. In MATLAB a property attribute can not be redefined for subclasses, so it was possible to set readonly properties.
How to test the behavior?
Checklist
fix #XX
whereXX
is the issue number?